[PATCH] libsframe: testsuite: Fix testsuite build on Solaris [PR33168]

[Rainer Orth]

Hi Alan,

>> > One could, of course, introduce a new sframe-test.h or some such which
>> > would only include those lines for now.  Seems a bit wasteful to me, but
>> > maybe clearer.
>> 
>> as an afterthough, it occured to me that one might as well introduce
>> such a header, moving *all* libsframe testsuite includes there together
>> with the above hack.  AFAICS, the set of headers included is almost
>> identical across all tests.
>
> That sounds like the way to go.

fine, patch coming.

>> > I'm really uncertain if the argument about removing
>> > AC_USE_SYSTEM_EXTENSIONS does hold water, though.  It bears some risk,
>> > of course, but as I said, it was only introduced into binutils for an
>> > obscure platform long gone, and thus carried forward to most other
>> > configure.ac's.  OTOH, it's not in gdb/testsuite, libdecnumber,
>> > readline, sim, and zlib, which makes me wonder even more about the
>> > necessity.
>> 
>> Even with some sframe-test.h, I still consider the jury to be out on the
>> necessity of AC_USE_SYSTEM_EXTENSIONS.  However, that should be
>> evaluated separately for the whole of binutils.  The situation may be
>> different there, however, since other parts of binutils most likely
>> include more system-specific stuff than libsframe does.
>
> Right.  We'd need someone with detailed knowledge of what
> AC_USE_SYSTEM_EXTENSIONS does on all the various hosts where binutils
> is likely to be built.  It's easy enough to see that on my linux
> machine it will define _GNU_SOURCE which enables some large file
> support among other things.  That conceivably changes binutils on
> 32-bit linux hosts, because not all directories invoke
> AC_SYS_LARGEFILE in their configure.ac.  I'm not interested enough to
> do the work necessary to remove AC_USE_SYSTEM_EXTENSIONS with any
> confidence.

Sound like a considerable (though necessary given the possible negative
impact).  I could test on Solaris, Linux, FreeBSD, and Darwin (if need
be and useful: I have no idea about the support for macOS/MachO, not
having tried that in ages), plus some systems in the cfarm.

However, I have too much on my plate right now to try that.  I could
file a PR if that's deemed helpful, though.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University