[PATCH] elf: Clear entsize when clearing SEC_MERGE|SEC_STRINGS

Alan Modra amodra@gmail.com
Thu Aug 21 08:30:14 GMT 2025


On Thu, Aug 21, 2025 at 08:44:26AM +0200, Jan Beulich wrote:
> On 20.08.2025 21:27, H.J. Lu wrote:
> > When generating an output from input SEC_MERGE|SEC_STRINGS sections with
> > different entsize, we clear the SEC_MERGE|SEC_STRINGS bits.  We also need
> > to clear entsize.
> > 
> > 	PR ld/33291
> > 	* ldlang.c (lang_add_section): Clearing entsize when clearing
> > 	SEC_MERGE|SEC_STRINGS.
> > 	* testsuite/ld-elf/pr33291.d: New file.
> > 	* testsuite/ld-elf/pr33291a.s: Likewise.
> > 	* testsuite/ld-elf/pr33291b.s: Likewise.
> 
> This is doing far less than my patch does, except for adding a testcase. I
> don't see why it was approved and committed in favor of mine. (There is also
> a wrong claim on the bug itself, which I'll comment on there.)

I approved HJ's patch because it seemed obviously correct as far as it
went, and it didn't occur to me that there might be a conflict.  (I'd
seen your patch but didn't look at it in any detail, thinking "Jan
knows what he's doing".)  Sorry if I've done the wrong thing by you.

-- 
Alan Modra


More information about the Binutils mailing list