[COMMITTED] gas: testsuite: fix regression in cfi-common-10.d
Indu Bhagat
indu.bhagat@oracle.com
Wed Aug 20 21:40:47 GMT 2025
On 8/20/25 1:42 PM, H.J. Lu wrote:
> On Tue, Aug 19, 2025 at 2:14 PM Indu Bhagat via Binutils
> <binutils@sourceware.org> wrote:
>>
>> A previous commit 09292f4ae2c introduced the new test cfi-common-10.d.
>> The testcase needs some adjustments for it to be useful on a variety of
>> targets.
>> ---
>> gas/testsuite/gas/cfi/cfi-common-10.d | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/gas/testsuite/gas/cfi/cfi-common-10.d b/gas/testsuite/gas/cfi/cfi-common-10.d
>> index 826e2364444..2261da47dfd 100644
>> --- a/gas/testsuite/gas/cfi/cfi-common-10.d
>> +++ b/gas/testsuite/gas/cfi/cfi-common-10.d
>> @@ -3,7 +3,7 @@
>> #...
>> Contents of the .eh_frame section:
>>
>> -00000000 0+0014 0+0000 CIE
>> +0+0000 0+00(10|14) 0+0000 CIE
>> Version: 1
>> Augmentation: "zR"
>> Code alignment factor: .*
>> @@ -12,7 +12,7 @@ Contents of the .eh_frame section:
>> Augmentation data: [01][abc]
>> #...
>>
>> -00000018 0+00(18|1c) 0+001c FDE cie=0+0000 pc=.*
>> +0+00(14|18) 0+00(18|1c) 0+00(18|1c) FDE cie=0+0000 pc=.*
>> #...
>> DW_CFA_advance_loc: 4 to 0+0004
>> DW_CFA_def_cfa_offset: 1099511627808
>> --
>> 2.43.0
>>
>
> I got
>
> /export/gnu/import/git/sources/binutils-gdb/gas/testsuite/gas/cfi/cfi-common-10.s:
> Assembler messages:
> /export/gnu/import/git/sources/binutils-gdb/gas/testsuite/gas/cfi/cfi-common-10.s:4:
> Error: bad or irreducible absolute expression
> failed with: </export/gnu/import/git/sources/binutils-gdb/gas/testsuite/gas/cfi/cfi-common-10.s:
> Assembler messages:
> /export/gnu/import/git/sources/binutils-gdb/gas/testsuite/gas/cfi/cfi-common-10.s:4:
> Error: bad or irreducible absolute expression>, no expected output
> FAIL: CFI common 10
>
> on Linux/i386.
>
> Isn't
>
> cfi_def_cfa_offset 1099511627808
>
> too big for 32-bit targets?
>
For 32-bit targets, true, this offset should not realistically occur.
Perhaps it is best to move this test as cfi-x86-64-3.s.
(I do have i386-darwin i386-lynxos in my regression script. I wonder why
this didnt show up as failure in my testing...)
More information about the Binutils
mailing list