[PATCH v3 1/7] Adjust pdata function table entries sorting for AArch64
Evgeny Karpov
evgeny@kmaps.co
Thu Aug 14 20:31:58 GMT 2025
Thu, Aug 14, 2025
Saurabh Jha <saurabh.jha@arm.com> wrote:
>> */
>> + #define FUNCTION_TABLE_ENTRY_SIZE 12
>> +#endif
> If this is being used at only one place, shouldn't we just have this if
> statement along with a local variable inside _bfd_XXi_final_link_postscript?
>
> If you are defining it here more for readability, maybe a single line
> comment explaining the purpose of this might be helpful. The name is
> descriptive enough but a comment explaining the context where it will be
> used.
Yes, it might be turned into a const and extended with a description
of what the table entry size means.
Regards,
Evgeny
More information about the Binutils
mailing list