[PATCH v2] LoongArch: Fix symbol size after relaxation
Lulu Cai
cailulu@loongson.cn
Fri Aug 8 01:53:02 GMT 2025
On 8/7/25 9:05 PM, WANG Xuerui wrote:
> On 8/6/25 12:19, Xi Ruoyao wrote:
>> [snip]
>>
>> diff --git a/bfd/elfnn-loongarch.c b/bfd/elfnn-loongarch.c
>> index 1ddea2f4f8c..8beb3d84079 100644
>> --- a/bfd/elfnn-loongarch.c
>> +++ b/bfd/elfnn-loongarch.c
>> @@ -4903,6 +4903,60 @@ loongarch_relax_delete_or_nop (bfd *abfd,
>> bfd_put (32, abfd, LARCH_NOP, contents + addr);
>> }
>> [snip]
>> + /* This shouldn't happen unless people write something really
>> insane like
>> + .reloc ., R_LARCH_ALIGN, 60
>> + .rept 15
>> + 1: nop
>> + .endr
>> + .set x, 1b
>> + .size x, . - 1b
>> + But let's just try to make it "work" anyway. */
>
> There is a trend of pushing the use of inclusive language in
> documentation, and I think "insane" is on one of the lists of words to
> be replaced. So maybe change "insane" to a neutral alternative like
> "unreasonable" or maybe "not resembling typical patterns".
>
> I will test the revised patch tomorrow but I expect it to pass, and my
> Tested-by tag to be preserved...
Hi Xuerui, This patch was pushed to master yesterday...
More information about the Binutils
mailing list