[PATCH] libbfd: Always compile plugin.c into libbfd

[H.J. Lu]

On Thu, Aug 7, 2025 at 4:29 PM Alan Modra <amodra@gmail.com> wrote:
>
> On Thu, Aug 07, 2025 at 06:47:18AM -0700, H.J. Lu wrote:
> > On Thu, Aug 7, 2025 at 6:37 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> > Checking BFD_SUPPORTS_PLUGINS all over the place only benefits
> > very small percentage of binutils users while everyone else pays the price.
>
> Your patch silently breaks ar compatibility for aix, hpux and vms.
> Problems like that are why I think we are better off making it
> possible to conditionally compile in plugin support.
>

My patch shouldn't change binutils behavior at all.  It only changes
the BFD_SUPPORTS_PLUGINS check from build time to run time.
If --disable-plugins is used, plugin is disabled at run time.  Probably
I should replace

#define BFD_SUPPORTS_PLUGINS @supports_plugins@

with

static inline bool
bfd_plugin_enabled (void)
{
  return @supports_plugins@;
}

My patch won't change aix, hpux and vms.

-- 
H.J.