PING: [PATCH v3] dwarf: Dump .debug_loclists only for DWARF-5

[H.J. Lu]

On Mon, Apr 28, 2025 at 2:02 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 28.04.2025 01:25, H.J. Lu wrote:
> > On Fri, Mar 28, 2025 at 1:21 AM H.J. Lu <hjl.tools@gmail.com> wrote:
> >>
> >> .debug_loclists section is loaded into debug_information as DWARF-5 debug
> >> info and .debug_loc section is loaded into debug_information as pre-DWARF-5
> >> debug info.  When dumping .debug_loc section, we should only process
> >> pre-DWARF-5 debug info in debug_information.  When dumping .debug_loclists
> >> section, we should only process DWARF-5 info in debug_information.
> >>
> >> binutils/
> >>
> >>         PR binutils/32809
> >>         * dwarf.c (display_debug_loc): Dump .debug_loclists only for
> >>         DWARF-5.
> >>
> >> ld/
> >>
> >>         PR binutils/32809
> >>         * testsuite/ld-x86-64/dwarf4.s: New file.
> >>         * testsuite/ld-x86-64/dwarf5a.s: Likewise.
> >>         * testsuite/ld-x86-64/dwarf5b.s: Likewise.
> >>         * testsuite/ld-x86-64/pr32809.d: Likewise.
> >>         * testsuite/ld-x86-64/x86-64.exp: Run pr32809.
> >>
> >> Signed-off-by: H.J. Lu <hjl.tools@gmail.com>
>
> From the looks of it there weren't significant changes in v3 (sadly you don't
> provide any rev log), so I wasn't thinking that my "okay" given over a month
> ago [1] would have been invalidated.

I added:

+/* Assembly outputs of
+
+extern void bar();
+
+void foo(int p) {
+  int local = p;
+  bar();
+  local = 123;
+  bar();
+  local = 456;
+}
+
+compiled by GCC 14.2.1 with -O2 -g -gdwarf-4.  */

to indicate how the assembly outputs were generated.  I don't think that
binutils assembly tests generated from compilers need to describe what
they do.

> Jan
>
> [1] https://sourceware.org/pipermail/binutils/2025-March/140156.html



-- 
H.J.