[PATCH v1 5/7] Write SEH records to pdata/xdata

[Evgeny Karpov]

Wednesday, April 9, 2025
Jan Beulich <jbeulich@suse.com> wrote:

> Are the two functions incapable of dealing with "nothing to emit"? The
> description is lacking details on why this and the below change to existing
> code are necessary.

The logic for "nothing to emit" will be moved into the functions, it is possible.

> Also, why XDELETE() when it was free() before?

The recent change fixed memory leaks by using
free(seh_ctx_cur);  
however seh_ctx_cur is allocated by XCNEW, which is connected with XDELETE  
to release memory. XDELETE uses the same free, however potentially,  
the implementation might be changed.

> Why plain int when both bounds are of an unsigned type (where in turn it's
> questionable whether they really need to be uint32_t, rather than unsigned
> int)?

Both variables are expected to be non-negative.
The variable in the loop will be changed to uint32_t.

> Here it's slightly different though: Only the braces want sliding in by two
> blanks.

All highlighted style corrections will be applied.

Regards,
Evgeny