[PATCH v6 1/3] bfd: properly use bfd_get_symbol_leading_char in peXXigen.

[Jeremy Drake]

On Fri, 4 Apr 2025, Jan Beulich wrote:

> With that last aspect you went a little too far:
>
> > @@ -4430,8 +4431,8 @@ _bfd_XXi_final_link_postscript (bfd * abfd, struct coff_final_link_info *pfinfo)
> >        else
> >  	{
> >  	  _bfd_error_handler
> > -	    (_("%pB: unable to fill in DataDictionary[1] because .idata$2 is missing"),
> > -	     abfd);
> > +	    (_("%pB: unable to fill in DataDirectory[%d]: %s not defined correctly"),
> > +	     abfd, PE_IMPORT_TABLE, ".idata$2");
>
> "is missing" is more precise than "not defined correctly", or at least more
> helpful to the user. It's a section after all, not a symbol. Same for the
> other .idata$<n> messages then, except for one (see below).

> This one I'm fine with. Still none of the above really belong in a patch under
> the given title, so I'd like to ask that we split things, keeping right here
> only what's further down (as it was before).
>
> Judging from earlier commits of yours it looks like you may not have commit
> rights. I'd be fine making said adjustments while committing on your behalf.

Sorry about that.  When you mentioned changing DataDictionary to
DataDirectory, I did a search and found several messages that were the
same.

Correct, I do not have rights to push.  I'd be fine with you making
whatever adjustments (such as adding a Reviewed-by if this is something
this project does) and pushing.  Thanks.