[PATCH] objdump: avoid possible SIGSEGV when printing debug info [BZ #32829]

[Collin Funk]

Jan Beulich <jbeulich@suse.com> writes:

> Some additional information might have been nice to provide here. From the
> bugzilla entry I get the feeling we're dealing with fuzzed input? That's
> relevant to at least mention. Further ...

I assumed that it was fuzzed as well, but the original report didn't
mention.

> I'd further raise the question whether two enums with no names/values
> ought to really be treated as being the same. Imo it's more likely that
> they're different (and there's no way to know for sure).
>
> In summary - imo if any of the four pointers is NULL, we'd better return
> false here.

That makes sense. I had the same thought that it it is impossible to
know when they are all NULL. I guess you are right though, better to
assume they are different than assume they are the same.

> As an aside - aiui the PR also wants mentioning in the description (in a
> recognizable form), for the bugzilla entry to be automatically updated
> when the eventual fix was committed / pushed. I'm not sure mentioning it
> in the title and in this form is sufficient.

Sorry, I should have checked the commit message rules more closely.
Glibc works with 'BZ #', but now I see GCC and Binutils use 'PR'. Not
sure if this is some shared sourceware thing to automatically update
Bugzilla or not.

Collin