[PATCH 2/2] binutils/testsuite: don't tail the same input and output file
Clément Chigot
chigot@adacore.com
Tue Apr 1 07:56:21 GMT 2025
The output file could be created before the input is gathered by tail,
erasing the later before it's being proceeded.
This happened on rare cases when performing remote tests on
Ubuntu 24.04.
---
binutils/testsuite/binutils-all/objdump.exp | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/binutils/testsuite/binutils-all/objdump.exp b/binutils/testsuite/binutils-all/objdump.exp
index bddb0cb618a..47d08734f79 100644
--- a/binutils/testsuite/binutils-all/objdump.exp
+++ b/binutils/testsuite/binutils-all/objdump.exp
@@ -595,8 +595,8 @@ if { ![is_elf_format] } then {
send_log "\n"
}
- set got [remote_exec host "tail -n +4 tmpdir/objdump.out" "" "/dev/null" "tmpdir/objdump.out"]
- set output [remote_upload host tmpdir/objdump.out]
+ set got [remote_exec host "tail -n +4 tmpdir/objdump.out" "" "/dev/null" "tmpdir/objdump-tailed.out"]
+ set output [remote_upload host tmpdir/objdump-tailed.out]
if ![file size $output] then {
# If the output file is empty, then this target does not
@@ -606,7 +606,7 @@ if { ![is_elf_format] } then {
return
}
- if { [regexp_diff tmpdir/objdump.out $srcdir/$subdir/dw5-op.W] } then {
+ if { [regexp_diff tmpdir/objdump-tailed.out $srcdir/$subdir/dw5-op.W] } then {
fail "objdump -Wi for DW_OP_*"
} else {
pass "objdump -Wi for DW_OP_*"
--
2.34.1
More information about the Binutils
mailing list