[PATCH] gprofng: avoid use of non-portable which [PR32166]

Sam James sam@gentoo.org
Thu Sep 12 21:55:40 GMT 2024


Vladimir Mezentsev <vladimir.mezentsev@oracle.com> writes:

> LGTM.
>
> Thank you for improving gprofng.

Thank you Vladimir! Pushed.

>
> -Vladimir
>
> On 9/11/24 14:03, Sam James wrote:
>> gprofng/ChangeLog
>> 	PR gprofng/32166
>> 	* testsuite/lib/Makefile.skel (JAVABIN): Replace use of which.
>> ---
>>   gprofng/testsuite/lib/Makefile.skel | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/gprofng/testsuite/lib/Makefile.skel b/gprofng/testsuite/lib/Makefile.skel
>> index 8ea994d2e59..2c98720c4c4 100644
>> --- a/gprofng/testsuite/lib/Makefile.skel
>> +++ b/gprofng/testsuite/lib/Makefile.skel
>> @@ -23,7 +23,7 @@ CFLAGS      = -g -Wall
>>   SHAREDOPT	= -fpic	-shared
>>     #JAVABIN = /usr/java/latest/bin
>> -JAVABIN = $(shell dirname `which java`)
>> +JAVABIN = $(shell dirname `command -v java`)
>>   JAVA    = $(JAVABIN)/java
>>   JAVAC   = $(JAVABIN)/javac
>>   base-commit: ad0751b6ecf40cb94ecb693d1acfc38fd223f408


More information about the Binutils mailing list