[PATCH] bfd/pdb: fix bitmap generation in pdb_write_bitmap

Mark Harmstone mark@harmstone.com
Wed Sep 4 01:23:12 GMT 2024


On 03/09/2024 07:07, Jan Beulich wrote:
> On 02.09.2024 21:19, Mark Harmstone wrote:
>> Thanks Jan. Pedantic because there's not really a reason for checking the
>> free-space bitmap, if you're opening a file readonly. The validation
>> function that was failing, MSF_HB::checkInvariants in msdia140.dll, is
>> behind an #ifdef _DEBUG in the open-source version,[0] which makes me think
>> that it's not there deliberately.
> 
> Oh, so you're talking of just read-only accesses. I was thinking of MS tools
> further modifying such a .pdb. I'd appreciate if you reworded the description
> to at least make clear that (perhaps) it is simply unknown what would have
> happened if such a .pdb was further modified. Okay to put in then.

No worries, will do. Thanks Jan

Mark



More information about the Binutils mailing list