[PATCH] i386: Move movabs check earlier in optimize_disp

[Jan Beulich]

On 30.10.2024 12:59, H.J. Lu wrote:
> On Wed, Oct 30, 2024, 7:07 PM Jan Beulich <jbeulich@suse.com> wrote:
> 
>> On 30.10.2024 11:24, H.J. Lu wrote:
>>> Move movabs check to the start of optimize_disp and drop unnecessary
>>> CODE_64BIT check as movabs is only available in 64-bit mode.
>>
>> The comment has been stale, not covering the disp_encoding part of the
>> conditional. I'm not (yet) convinced that check can also be moved; it
>> certainly would need mentioning in the description (if nothing else
>> than to at least clarify the movement is intentional).
> 
> Do you have a test case to show that it can't be moved?

Not off the top of my head. But isn't it you anyway who needs to explain
why it's fine to be moved? (Hence why I asked to mention this in the
description.)

Jan