[PATCH] i386: Move movabs check earlier in optimize_disp

Jan Beulich jbeulich@suse.com
Wed Oct 30 11:07:17 GMT 2024


On 30.10.2024 11:24, H.J. Lu wrote:
> Move movabs check to the start of optimize_disp and drop unnecessary
> CODE_64BIT check as movabs is only available in 64-bit mode.

The comment has been stale, not covering the disp_encoding part of the
conditional. I'm not (yet) convinced that check can also be moved; it
certainly would need mentioning in the description (if nothing else
than to at least clarify the movement is intentional).

I definitely agree with the dropping of the redundant part of the
condition.

Jan


More information about the Binutils mailing list