[PATCH v2 2/2] x86/APX: support JMPABS also in assembler

[H.J. Lu]

On Mon, Oct 28, 2024 at 4:13 PM Jan Beulich <jbeulich@suse.com> wrote:
>
> On 19.10.2024 00:40, H.J. Lu wrote:
> > On Fri, Oct 18, 2024, 8:08 PM Jan Beulich <jbeulich@suse.com> wrote:
> >> @@ -8361,10 +8380,10 @@ optimize_disp (const insn_template *t)
> >>         }
> >>      }
> >>
> >> -  /* Don't optimize displacement for movabs since it only takes 64bit
> >> -     displacement.  */
> >> +  /* Don't optimize displacement for movabs / jmpabs since they only take
> >> +     64-bit displacement.  */
> >>    if (pp.disp_encoding > disp_encoding_8bit
> >> -      || (flag_code == CODE_64BIT && t->mnem_off == MN_movabs))
> >> +      || t->mnem_off == MN_movabs || t->mnem_off == MN_jmpabs)
> >>
> >
> > Is this needed for AT&T syntax?
>
> No, but the check is benign there and hence adding yet another part to
> the conditional would only be detrimental to performance, without
> gaining us anything.
>
> > Is there 64bit displacement in the spec?
>
> As before - that depends on how one reads the spec.
>

Lili, please ask the spec author for clarification.


-- 
H.J.