[PATCH v2] x86: Support ZHAOXIN GMI instructions

mayshao-oc mayshao-oc@zhaoxin.com
Thu Oct 17 02:17:36 GMT 2024


Hi Jan:
        I move the conditional check ahead, and update the patch. Thanks 
for your comments.

BR
Mayshao

On 10/16/24 17:22, Jan Beulich wrote:
> 
> 
> 
> On 16.10.2024 09:48, mayshao-oc wrote:
>> On 10/16/24 14:47, Jan Beulich wrote:
>>> On 15.10.2024 13:44, mayshao-oc wrote:
>>>>          Thanks for your patience, and I refine the patch to name the
>>>> enumerators properly.
>>>
>>> Just one remaining issue: In your switching to the use of OP_Skip_MODRM()
>>> you lost (or forgot to add?) the ins->modrm.rm != 0 check that the mis-
>>> named OP_0f07() has, and that also applies to these new insns (aiui) >
>>
>>         Thanks for your review. I fix the issue, ok for trunk?
> 
> Mind me asking to move the new conditional ahead of the one that was
> already there in (plain) v3? Okay with that adjustment, but before
> committing please give Haochen a day or two for possible further
> remarks / requests.
> 
> Jan
-------------- next part --------------
A non-text attachment was scrubbed...
Name: gmi_v3_if_ahead.patch
Type: text/x-patch
Size: 8571 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20241017/2539201e/attachment.bin>


More information about the Binutils mailing list