[PATCH v2 2/2] bfd/ELF: drop align_file_position()

Jan Beulich jbeulich@suse.com
Fri Oct 4 07:32:01 GMT 2024


Switch the sole user to BFD_ALIGN() instead. (It's comment was partly
wrong [stale?] anyway, talking of some maximum that was nowhere in
sight.)
---
v2: New.

--- a/bfd/elf.c
+++ b/bfd/elf.c
@@ -4547,15 +4547,6 @@ elf_map_symbols (bfd *abfd, unsigned int
   return true;
 }
 
-/* Align to the maximum file alignment that could be required for any
-   ELF data structure.  */
-
-static inline file_ptr
-align_file_position (file_ptr off, int align)
-{
-  return (off + align - 1) & ~(align - 1);
-}
-
 /* Assign a file position to a section, optionally aligning to the
    required section alignment.  */
 
@@ -7106,7 +7097,7 @@ _bfd_elf_assign_file_positions_for_non_l
 
   /* Place the section headers.  */
   i_ehdrp = elf_elfheader (abfd);
-  off = align_file_position (off, 1 << bed->s->log_file_align);
+  off = BFD_ALIGN (off, 1u << bed->s->log_file_align);
   i_ehdrp->e_shoff = off;
   off += i_ehdrp->e_shnum * i_ehdrp->e_shentsize;
   elf_next_file_pos (abfd) = off;



More information about the Binutils mailing list