[PATCH] dwarf: fix reading indexed strings

[Oleg Tolmatcev]

Hello,

I created an executable with clang and DWARF5. When running "objdump
-Wi" I get the following warning: "objdump: Warning: indirect offset
too big". Patch that fixes it is attached.

BTW the Windows build is broken, will send patch later.

objdump before:
 <0><1543>: Abbrev Number: 1 (DW_TAG_compile_unit)
    <1544>   DW_AT_producer    : (indexed string: 0): <indirect index
offset is too big>
    <1545>   DW_AT_language    : 33    (C++14)
    <1547>   DW_AT_name        : (indexed string: 0x1): <indirect
index offset is too big>
    <1548>   DW_AT_str_offsets_base: 0x8

 llvm-dwarfdump:
0x00001543: DW_TAG_compile_unit [1] *
              DW_AT_producer [DW_FORM_strx1]    (indexed (00000000)
string = "clang version 19.1.4")
              DW_AT_language [DW_FORM_data2]    (DW_LANG_C_plus_plus_14)
              DW_AT_name [DW_FORM_strx1]    (indexed (00000001) string
= "C:/src/drmingw/tests/test_mgwhelp.cpp")
              DW_AT_str_offsets_base [DW_FORM_sec_offset]    (0x00000008)

objdump after:
 <0><1543>: Abbrev Number: 1 (DW_TAG_compile_unit)
    <1544>   DW_AT_producer    : (indexed string: 0): clang version 19.1.4
    <1545>   DW_AT_language    : 33     (C++14)
    <1547>   DW_AT_name        : (indexed string: 0x1):
C:/src/drmingw/tests/test_mgwhelp.cpp
    <1548>   DW_AT_str_offsets_base: 0x8

Best regards
Oleg Tolmatcev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-dwarf-fix-reading-indexed-strings.patch
Type: application/x-patch
Size: 759 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20241130/c8ead977/attachment-0001.bin>