[PATCH v4 1/2] gas: add new command line options to control diagnostic information messages

[Jan Beulich]

On 20.11.2024 19:24, Matthieu Longo wrote:
> --- a/gas/as.h
> +++ b/gas/as.h
> @@ -323,6 +323,9 @@ COMMON int flag_no_warnings; /* -W, --no-warn */
>  /* True if warnings count as errors.  */
>  COMMON int flag_fatal_warnings; /* --fatal-warnings */
>  
> +/* True if infos should be inhibited.  */
> +COMMON int flag_no_information; /* --no-info */

While I understand most pre-existing boolean flag_* variables use int, a
few already properly use bool (and then true/false when writing to them).
I think this should be followed for all new such variables.

> --- a/gas/doc/as.texi
> +++ b/gas/doc/as.texi
> @@ -243,6 +243,7 @@ gcc(1), ld(1), and the Info entries for @file{binutils} and @file{ld}.
>   [@b{--gsframe}]
>   [@b{--hash-size}=@var{N}]
>   [@b{--help}] [@b{--target-help}]
> + [@b{--info}] [@b{--no-info}]
>   [@b{-I} @var{dir}]
>   [@b{-J}]
>   [@b{-K}]
> @@ -873,6 +874,12 @@ Print a summary of the command-line options and exit.
>  @item --target-help
>  Print a summary of all target specific options and exit.
>  
> +@item --info
> +Don't suppress information messages.
> +
> +@item --no-info
> +Suppress information messages.

While I'm not a native speaker, I think throughout from here onwards you want
to replace "information" by "informational" and ...

> @@ -2558,6 +2566,32 @@ preprocessed (if they contain comments, for example), @command{@value{AS}} does
>  not work correctly.
>  @end quotation
>  
> +@node info
> +@section Control Information Messages: @option{--info}, @option{--no-info}
> +
> +In some cases, @command{@value{AS}} might give an additional information message
> +associated to a context that generated a warning or error message when assembling.
> +The information message provides additional details about an earlier diagnostic
> +message, usually in the form of some context (such as when the earlier diagnostic
> +was within a macro).
> +All such informations are directed to the standard error file.

... "informations" by "information" (afaik there's no plural of this word).

Further, in the first sentence of this paragraph I think you want to switch
"message" to plural (dropping "an").

With respective adjustments: Okay.

Jan