[PATCH v3] Support Intel AVX10.2 BF16 instructions

Jiang, Haochen haochen.jiang@intel.com
Fri Nov 29 02:17:56 GMT 2024


> From: Jan Beulich <jbeulich@suse.com>
> Sent: Friday, November 29, 2024 12:59 AM
> 
> On 26.11.2024 09:48, Haochen Jiang wrote:
> >
> > I would like to send out the v3 patch even before the doc is published
> > since the change is pretty clear on mnemonics and we need to catch up
> > with Binutils 2.44 while there are still several patches and topics
> > undergoing. Need to close some of them first and endless waiting is
> > definitely not the best choice.
> >
> > v3 patch comes following with changes and patch description.
> >
> > Ok for trunk?
> >
> > ---
> >
> > Changes in v3:
> >
> >   - Update mnemonics for scalef: VSCALEFPBF16 -> VSCALEFNEPBF16.
> >   - Mix tests w/ and w/o broadcast and size specifiers.
> >   - Adjust paddings in disassemler table.
> >   - Put %XB after %XH in comments and use oappend to handle that.
> >
> > ---
> >
> > In this patch, we will support AVX10.2 BF16 instructions. All of them
> > are new instructions forms.
> >
> > In disassembler part, we added %XB to reduce W table pass since all
> > of them get evex.w=0.
> >
> > ---
> >
> > Changes in v2:
> >
> >   - Update vgetexppbf16 encoding: 66.MAP5.42 --> NP.MAP6.42
> >
> > ---
> 
> By this point it isn't really clear what part(s) is/are intended to be
> part of the eventual commit. The deviation from the public spec clearly
> should be mentioned there, while at the same time the "Changes in v..."
> don't belong there.

Yes, I will mention that in the final description if docs are not ready when
I commit the patch.

> 
> > @@ -10510,6 +10528,13 @@ putop (instr_info *ins, const char
> *in_template, int sizeflag)
> >
> >  	      goto case_B;
> >  	    }
> > +	  else if (l && last[0] == 'X')
> > +	    {
> > +	      if (ins->vex.w == 0)
> 
> My request still stands: Please don't use == or != on boolean values.
> 
> With these 2 points taken care of: Okay.

Oh, I forgot vex.w here. I will change that when commit.

Thx,
Haochen


More information about the Binutils mailing list