Re: 回复： Re: RISCV: Support Zilsd and Zcmlsd extensions.

[Jan Beulich]

On 27.11.2024 08:20, 孙东亚 wrote:
> Thanks for your advise and based on the provided suggestions, the following modifications have been made:
> 1. Renamed zcmlsd to zclsd according to upstream changes : https://github.com/riscv/riscv-zilsd.
> 
> 2. Re-adapted the patch on the master branch based on the latest version of binutils.
> 3. Modified the indentation of the patch to make it more standardized.
> 4. For all new instructions, a test case has been added.

Why is it that the Zilsd insns have their register operands properly constrained
to even numbers, but the Zclsd ones don't? You even appear to have wrong uses of
the insns in the supposedly-valid testcases.

I further wonder why you introduce new Gd and Gt operand forms, when Zacas handles
the quite similar situation for the pair AMOCAS forms differently, without
consuming another precious letter ('G'). Consistency in handling is an imo
worthwhile goal.

As to the splitting of testcases: Each test comes with some overhead. Therefore
I'd like to recommend that testcases for the different insns of the same
extension be combined, resulting in slightly better time and space efficiency.

Also please take care of the various "\ No newline at end of file" in the patch.

Jan