[PATCH] gprofng: fix -std=gnu23 compatibility wrt unprototyped functions

Vladimir Mezentsev vladimir.mezentsev@oracle.com
Sun Nov 17 22:02:16 GMT 2024



On 11/15/24 22:45, Sam James wrote:
> C23 removes support for unprototyped functions. Fix function pointer types
> accordingly.
>
> ChangeLog:
> 	PR gprofng/32374
>
> 	* gprofng/libcollector/collector.c (collector_sample): Fix prototype.
> 	* gprofng/libcollector/dispatcher.c (setitimer): Ditto.
> 	* gprofng/libcollector/envmgmt.c (putenv): Ditto.
> 	(_putenv): Ditto.
> 	(__collector_putenv): Ditto.
> 	(setenv): Ditto.
> 	(_setenv): Ditto.
> 	(__collector_setenv): Ditto.
> 	(unsetenv): Ditto.
> 	(_unsetenv): Ditto.
> 	(__collector_unsetenv): Ditto.
> 	* gprofng/libcollector/jprofile.c (open_experiment): Ditto.
> 	(__collector_jprofile_enable_synctrace): Ditto.
> 	(jprof_find_asyncgetcalltrace): Ditto.
> 	* gprofng/libcollector/libcol_util.c (__collector_util_init): Ditto.
> 	(ARCH): Ditto.
> 	* gprofng/libcollector/mmaptrace.c (collector_func_load): Ditto.
> 	(collector_func_unload): Ditto.
> 	* gprofng/libcollector/unwind.c (__collector_ext_unwind_init): Ditto.
> 	* gprofng/src/collector_module.h: Ditto.
> ---
> Vladimir, does this look OK? It's not complete (see PR32374, PR32373), but
> it fixes almost everything.

Looks good to me.

Thank you for your work on gprofng.

-Vladimir



More information about the Binutils mailing list