[PATCH 1/4] gas/ELF: also reject merge entity size being zero

Jan Beulich jbeulich@suse.com
Mon Nov 11 08:43:08 GMT 2024


This won't have any useful effect, so is at best marginally less bogus
than a negative value.

The change actually points out a flawed (for Arm) testcase: @ is a
comment character there.

--- a/gas/config/obj-elf.c
+++ b/gas/config/obj-elf.c
@@ -1327,7 +1327,7 @@ obj_elf_section (int push)
 		goto fetch_entsize;
 	      entsize = get_absolute_expression ();
 	      SKIP_WHITESPACE ();
-	      if (entsize < 0)
+	      if (entsize <= 0)
 		{
 		  as_warn (_("invalid merge entity size"));
 		  attr &= ~SHF_MERGE;
--- a/binutils/testsuite/binutils-all/debug_str.s
+++ b/binutils/testsuite/binutils-all/debug_str.s
@@ -8,5 +8,5 @@
 	resulting size was gigantic and consequently the library quickly ran out
 	of memory.  */
 
-	.section	.debug_str,"MS",@progbits,1
+	.section	.debug_str,"MS",%progbits,1
 	.string	"ZLIB_VER_SUBREVISION 0"



More information about the Binutils mailing list