[PATCH] bfd: Remove unused static find function from doc/chew.c

[Mark Wielaard]

Hi Jan,

On Fri, Nov 08, 2024 at 08:18:01AM +0100, Jan Beulich wrote:
> On 07.11.2024 18:40, Mark Wielaard wrote:
> > After commit 2e60790cf7c27d79f90f2dcb81e1930dc980bc1c "Remove the
> > paramstuff word" there is no caller left of the static find function
> > in doc/chew.c, so it can be removed.
> > 
> >    * doc/chew.c (find): Remove.
> 
> In case it's not deemed obvious anyway: Okay. Please consider replacing
> "can be" by "should be",

Pushed with that commit wording change.

> though - I'm surprised this didn't cause build
> issues, as compilers typically warn about unused statics.

bfd/doc/chew.c is compiled without warning flags enabled because it
has a special rule in bfd/doc/local.mk that doesn't include
WARN_CFLAGS_FOR_BUILD.

Maybe it should because enabling that flag shows various
warning/errors that should probably be cleaned up.

Cheers,

Mark