[PATCH v3 2/2] arm, objdump: print obsolote warning when 26-bit set in instructions

[Richard Earnshaw (lists)]

On 01/11/2024 10:26, Andre Vieira wrote:
> 
> Arm has obsoleted the 26-bit addressing mode. Diagnose this when disasembling
> these instructions by printing OBSOLETE.
> ---
>  gas/testsuite/gas/arm/armv1.d      |  8 +++---
>  gas/testsuite/gas/arm/inst.d       | 32 +++++++++++-----------
>  gas/testsuite/gas/arm/pinsn.d      | 24 ----------------
>  gas/testsuite/gas/arm/pinsn.s      | 16 -----------
>  gas/testsuite/gas/arm/wince_inst.d | 32 +++++++++++-----------
>  opcodes/arm-dis.c                  | 44 +++++++++++++-----------------
>  6 files changed, 55 insertions(+), 101 deletions(-)
>  delete mode 100644 gas/testsuite/gas/arm/pinsn.d
>  delete mode 100644 gas/testsuite/gas/arm/pinsn.s
> 
@@ -3359,6 +3359,7 @@ static const struct mopcode32 mve_opcodes[] =
    %m			print register mask for ldm/stm instruction
    %o			print operand2 (immediate or register + shift)
    %p			print 'p' iff bits 12-15 are 15
+   %O			print OBSOLETE if the 26-bit mode bit is set

I was slightly confused by this on first reading.  Perhaps better to largely copy the text from the line immediately above:

+   %O			print OBSOLETE iff bits 12-15 are 15

Otherwise this is OK.

R.