[PATCH v2 2/7][Binutils] aarch64: Fix sve2p1 dupq instruction operands.

srinath srinath.parvathaneni@arm.com
Wed May 22 10:04:30 GMT 2024


Hi,

This patch fixes the syntax of sve2p1 "dupq" instruction by modifying the way
2nd operand does the encoding and decoding using the [<imm>] value.

dupq makes use of already existing aarch64_ins_sve_index and aarch64_ext_sve_index
inserter and extractor functions. The definitions of aarch64_ins_sve_index_imm (inserter)
and aarch64_ext_sve_index_imm (extractor) is removed in this patch.

This issues was reported here:
 https://sourceware.org/pipermail/binutils/2024-February/132408.html

Regression testing for aarch64-none-elf target and found no regressions.

Ok for binutils master?

Regards,
Srinath.
---
 gas/testsuite/gas/aarch64/sve2p1-1-bad.l     |  8 ----
 gas/testsuite/gas/aarch64/sve2p1-1.d         |  8 ----
 gas/testsuite/gas/aarch64/sve2p1-1.s         |  9 ----
 gas/testsuite/gas/aarch64/sve2p1-2-invalid.d |  3 ++
 gas/testsuite/gas/aarch64/sve2p1-2-invalid.l | 47 ++++++++++++++++++++
 gas/testsuite/gas/aarch64/sve2p1-2-invalid.s | 10 +++++
 gas/testsuite/gas/aarch64/sve2p1-2.d         | 34 ++++++++++++++
 gas/testsuite/gas/aarch64/sve2p1-2.s         | 28 ++++++++++++
 include/opcode/aarch64.h                     |  2 +-
 opcodes/aarch64-asm.c                        | 19 +-------
 opcodes/aarch64-asm.h                        |  1 -
 opcodes/aarch64-dis.c                        | 36 ++-------------
 opcodes/aarch64-dis.h                        |  1 -
 opcodes/aarch64-tbl.h                        | 11 ++---
 14 files changed, 134 insertions(+), 83 deletions(-)
 create mode 100644 gas/testsuite/gas/aarch64/sve2p1-2-invalid.d
 create mode 100644 gas/testsuite/gas/aarch64/sve2p1-2-invalid.l
 create mode 100644 gas/testsuite/gas/aarch64/sve2p1-2-invalid.s
 create mode 100644 gas/testsuite/gas/aarch64/sve2p1-2.d
 create mode 100644 gas/testsuite/gas/aarch64/sve2p1-2.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-PATCH-v2-2-7-Binutils-aarch64-Fix-sve2p1-dupq-instru.patch
Type: text/x-patch
Size: 15042 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20240522/0427bf87/attachment-0001.bin>


More information about the Binutils mailing list