[PATCH] aarch64: Add support for the fpmr system register

Richard Earnshaw (lists) Richard.Earnshaw@arm.com
Fri May 17 16:22:48 GMT 2024


On 26/04/2024 16:00, Claudio Bantaloukas wrote:
> 
> AArch64 defines a read-write system register called fpmr.
> This floating point mode register controls behaviours of the FP8 instructions.
> This patch adds support for reading and writing along with relevant tests.
> Regression tested on the aarch64-none-elf and aarch64-none-linux-gnu targets
> and no regressions were found.
> 
> ---
> 
> Hi,
> 
> Is this Ok for master? I do not have commit rights, if OK, can someone commit on my behalf please?
> 
> Thanks,
> Claudio Bantaloukas
> 
>  .../gas/aarch64/sysreg/fp8-feature-enables-fpmr.d    | 12 ++++++++++++
>  .../gas/aarch64/sysreg/fpmr-unsupported-by-default.d |  4 ++++
>  .../gas/aarch64/sysreg/fpmr-unsupported-by-default.l |  3 +++
>  gas/testsuite/gas/aarch64/sysreg/fpmr.s              |  4 ++++
>  opcodes/aarch64-sys-regs.def                         |  1 +
>  5 files changed, 24 insertions(+)
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fp8-feature-enables-fpmr.d
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr-unsupported-by-default.d
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr-unsupported-by-default.l
>  create mode 100644 gas/testsuite/gas/aarch64/sysreg/fpmr.s
> 

This is OK.  But could you please add to the commit message something related to the fact that we've chosen to gate this with FEAT_FP8 rather than FEAT_FPMR as the latter only adds this register and FP8 requires this feature.

R.


More information about the Binutils mailing list