[PATCH] gas: Fix \+ expansion for .irp and .irpc

Hans-Peter Nilsson hp@axis.com
Thu May 16 01:54:43 GMT 2024


> From: Fangrui Song <maskray@google.com>
> Date: Wed, 15 May 2024 18:30:26 -0700

> On Wed, May 15, 2024 at 5:47 PM Hans-Peter Nilsson <hp@axis.com> wrote:
> >
> > > Date: Wed, 15 May 2024 00:04:02 -0700
> > > From: Fangrui Song <maskray@google.com>
> >
> > > From: Fangrui Song <maskray@gcc.gnu.org>
> > >
> > > .irp and .irpc receive a null macro_entry.  \+ causes a crash after the
> > > recent \+ support.  Restore the previous behavior.
> >
> > This patch (your commit b1d28350499d) caused the gas macro
> > test again to fail for cris-* e.g. cris-elf.  Please have a
> > look.  Thanks.
> >
> > brgds, H-P
> 
> Sorry for the breakage. Does this work for you?

No.  This test has passed for cris-elf in the past.

IMO you should instead move your recent additions to that
test to a *new* test.  Never *add* to a test-case!

brgds, H-P


More information about the Binutils mailing list