[PATCH, V2] gas: gcfg: fix handling of non-local direct jmps in gcfg

Jan Beulich jbeulich@suse.com
Thu Mar 28 16:35:20 GMT 2024


On 28.03.2024 17:26, Indu Bhagat wrote:
> On 3/28/24 03:10, Jan Beulich wrote:
>> On 28.03.2024 08:59, Indu Bhagat wrote:
>>> [Changes in V2]
>>>    - Add function level comments for ginsn_direct_local_jump_p.
>>>    - Add a jmp to locally defined label in the testcase to make it more
>>>      complete.  Also, add a jmp to label defined in another function.
>>>      The testcase now generates an additional warning (as expected):
>>>      "Warning: GINSN: found unreachable code in func 'bar'"
>>
>> For this - can't you simply omit the unreachable pair of insns?
> 
> We do omit those instructions from GCFG and SCFI.  GAS does, however, 
> warn for now. Do you mean skip this warning too?

No, I'm talking of only this one new testcase.

Jan


More information about the Binutils mailing list