[PATCH 1/3] gas: sanitize FB- and dollar-label uses

[Jan Beulich]

Nick,

On 26.03.2024 10:58, Nick Clifton wrote:
>    I just one, very minor comment:
> 
>> -  int small;			/* True if fits in 32 bits.  */
>> +  int small;		/* True if fits in 32 bits (64 bits with BFD64).  */
> 
>    I think that this should be:
> 
>       bool small;       /* True if fits in 32 bits (64 bits with BFD64).  */
> 
>    It irks me when types are used incorrectly, and given that we have
>    a boolean type, I feel that it should be used wherever it make sense.
> 
>    This is obviously not critical, so please feel free to ignore the
>    suggestion if you do not agree with it.

actually I'm glad you mention it. I was meaning to switch to bool, but
then I wasn't sure whether such would be liked as a "side effect" of
another change. You indicating (as to my reading) that it would, I'll
be happy to make type adjustments here and elsewhere (there are a lot
more places where in particular "bool" is meant when "int" is used),
when touching stuff anyway.

Jan