[PATCH] bfd: Don't call bfd_write with 0 size

H.J. Lu hjl.tools@gmail.com
Wed Mar 13 13:31:15 GMT 2024


On Tue, Mar 12, 2024 at 2:04 PM H.J. Lu <hjl.tools@gmail.com> wrote:
>
> There is no need to call bfd_write with 0 size.
>
>         * elf-strtab.c (_bfd_elf_strtab_emit): Don't call bfd_write with
>         0 size.
> ---
>  bfd/elf-strtab.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/bfd/elf-strtab.c b/bfd/elf-strtab.c
> index 5fdfac12bde..b6c62f15fa0 100644
> --- a/bfd/elf-strtab.c
> +++ b/bfd/elf-strtab.c
> @@ -326,7 +326,7 @@ _bfd_elf_strtab_emit (register bfd *abfd, struct elf_strtab_hash *tab)
>
>        BFD_ASSERT (tab->array[i]->refcount == 0);
>        len = tab->array[i]->len;
> -      if ((int) len < 0)
> +      if ((int) len <= 0)
>         continue;
>
>        str = tab->array[i]->root.string;
> --
> 2.44.0
>

I am checking it in.

-- 
H.J.


More information about the Binutils mailing list