[PATCH 07/11] gas: consistently drop trailing whitespace when scrubbing

Maciej W. Rozycki macro@orcam.me.uk
Fri Jun 28 13:53:31 GMT 2024


On Fri, 28 Jun 2024, Jan Beulich wrote:

> >From especially the checks for the two separator forms it appears to

 Accidental `>' here?

> In the MIPS testsuite adjustments I wasn't sure how exactly to make the
> necessary changes: I could also have zapped the two blanks each, but
> then I wondered why they were part of the expectations in the first
> place.

 Please do.

 The only reason I can think of why the patterns are such as they are is 
that they need to match the output as it has been produced.  It made no 
sense to make whitespace matching optional when said whitespace is always 
there.

 Of course I could have investigated why this extraneous whitespace is 
present there in the first place, but either I chose it wasn't worth it or 
I missed it in the eyeball review of the output produced; there are only 
two among 133 lines and not key to the purpose of the test case.  It's 
been a while, I genuinely do not remember.

 Thank you for making this clean-up, and taking care of the MIPS port in 
particular.

  Maciej


More information about the Binutils mailing list