[PATCH v2 2/5] LoongArch: Fix bad reloc with mixed visibility ifunc symbols in shared libraries
Xi Ruoyao
xry111@xry111.site
Fri Jun 28 12:39:48 GMT 2024
On Fri, 2024-06-28 at 17:40 +0800, Jinyang He wrote:
> > + Now normal_ifuncs first. */
> > + elf_link_hash_traverse (&htab->elf,
> > + elfNN_allocate_ifunc_dynrelocs_ref_global, info);
> > +
> > + /* Now hidden_ifuncs ifuncs. */
>
> LGTM. It makes logic clear and simple!
>
> Update "hidden_ifuncs" in the third patch?
Yes absolutely. Actually I've seen this typo at least twice myself but
I just forgot to fix it each time :(.
Thanks for the reminder.
> > + elf_link_hash_traverse (&htab->elf,
> > + elfNN_allocate_ifunc_dynrelocs_ref_local, info);
> > +
> > + /* Finally local ifuncs. */
> > htab_traverse (htab->loc_hash_table,
> > elfNN_allocate_local_ifunc_dynrelocs, info);
--
Xi Ruoyao <xry111@xry111.site>
School of Aerospace Science and Technology, Xidian University
More information about the Binutils
mailing list