[PATCH v4 01/15] x86: Remove unused SFrame CFI RA register variable

Jan Beulich jbeulich@suse.com
Mon Jun 24 14:51:13 GMT 2024


On 24.06.2024 16:23, Jens Remus wrote:
> gas/
> 	* config/tc-i386.c: Remove unused SFrame CFI RA register
> 	variable.

Nit: The more "canonical" way would be

	* config/tc-i386.c (x86_sframe_cfa_ra_reg): Remove.

> Reviewed-by: Andreas Krebbel <krebbel@linux.ibm.com>
> Reviewed-by: Indu Bhagat <indu.bhagat@oracle.com>
> Acked-by: Jan Beulich <jbeulich@suse.com>
> Signed-off-by: Jens Remus <jremus@linux.ibm.com>

As to these tags, besides them wanting to be in chronological order,
would you mind pointing out where these were taken from? I've checked
and I have no record of having offered an Acked-by:, and I also
couldn't find any Reviewed-by anywhere on the list. I don't know how
bad it really is (so please forgive if the wording is stronger than
actually needed here), but I don't think tags should be falsified. I
may be entirely wrong, though.

With the (tag free) replies you've got, I don't think there would
have been a need to re-post anyway - you could simply have committed
the adjusted form.

Finally the title says 01/15, yet by now (about 20 min after the mail
arrived) I didn't get any further parts of such a 15-patch series.
Oddly enough [1] doesn't even have this one, yet I don't know how
often it would be refreshed.

I'm sorry for the ranting,
Jan

[1] https://sourceware.org/pipermail/binutils/2024-June/thread.html



More information about the Binutils mailing list