[PATCH v1 04/11] [Binutils] aarch64: Fix sve2p1 extq instruction operands.

[Jan Beulich]

On 12.06.2024 17:59, srinath wrote:
> 
> Hi,
> 
> This patch fixes the syntax of sve2p1 "extq" instruction by modifying the operands
> count to 4. A new operand AARCH64_OPND_SVE_UIMM4 is defined to handle the 4th
> argument an 4-bit unsigned immediate of extq instruction. The instruction encoding
> is updated to use constraint C_SCAN_MOVPRFX, to enable "extq" instruction to immediately
> precede in program order by a MOVPRFX instruction.
> 
> This issues was reported here:
>  https://sourceware.org/pipermail/binutils/2024-February/132408.html
> 
> Regression testing for aarch64-none-elf target and found no regressions.
> 
> Ok for binutils master?
> 
> Regards,
> Srinath.
> ---
>  gas/config/tc-aarch64.c                      |  1 +
>  gas/testsuite/gas/aarch64/sve2p1-1-bad.l     |  6 ------
>  gas/testsuite/gas/aarch64/sve2p1-1.d         |  6 ------
>  gas/testsuite/gas/aarch64/sve2p1-1.s         |  6 ------
>  gas/testsuite/gas/aarch64/sve2p1-3-invalid.d |  3 +++
>  gas/testsuite/gas/aarch64/sve2p1-3-invalid.l | 17 +++++++++++++++++
>  gas/testsuite/gas/aarch64/sve2p1-3-invalid.s | 16 ++++++++++++++++
>  gas/testsuite/gas/aarch64/sve2p1-3.d         | 20 ++++++++++++++++++++
>  gas/testsuite/gas/aarch64/sve2p1-3.s         | 12 ++++++++++++
>  include/opcode/aarch64.h                     |  1 +
>  opcodes/aarch64-opc.c                        |  5 ++++-
>  opcodes/aarch64-tbl.h                        |  4 +++-

Since here you remove the sole user of SVE_Zm_imm4, shouldn't that operand
type then also be purged (much like you did in patch 2)?

Jan

>  12 files changed, 77 insertions(+), 20 deletions(-)
>  create mode 100644 gas/testsuite/gas/aarch64/sve2p1-3-invalid.d
>  create mode 100644 gas/testsuite/gas/aarch64/sve2p1-3-invalid.l
>  create mode 100644 gas/testsuite/gas/aarch64/sve2p1-3-invalid.s
>  create mode 100644 gas/testsuite/gas/aarch64/sve2p1-3.d
>  create mode 100644 gas/testsuite/gas/aarch64/sve2p1-3.s
>