Fix PR 31956 causes new --wrap problems

[Sam James]

Nick Clifton <nickc@redhat.com> writes:

> Hi H.J.

Hi Nick,
>
>   It seems that your v2 patch for PR 31956 is causing build problems
>   for PCP in Fedora Rawhide (BZ 2301454).  At least I have found that
>   reverting the patch fixes the PCP build issue.  Could you take a look
>   please and see if there is an additional fix that is needed of if the
>   v2 patch needs to be removed from upstream.  (Ideally before this
>   weekend if possible as I am about to make the 2.43 release...)
>
>   Thanks.

I started to look at this to see if I could at the least reproduce it
and extract+minimise a testcase.

So far, I haven't managed to reproduce the issue. Building with the
default flags, it builds OK. If I build with LTO, it fails a while
before the testsuite with a different error.

Now, as the reporter of PR31956, it is OK as far as I'm concerned if
we revert the patch on the branch *but* I will note that -Wl,--wrap with
LTO has always been pretty brittle (several packages fail for us
pre-PR31956) and I would argue it would be an OK workaround downstream
to disable LTO there too.

If I'm wrong and this is happening without LTO, that's a different
matter. I also wonder if the issue only shows up with -ffat-lto-objects
(not checked).

Could you or Nathan file a Binutils PR with some instructions that
reproduce the failure from a pcp tarball? I will try a bit more later but
so far no luck.

>
> Cheers
>   Nick
>
> https://bugzilla.redhat.com/show_bug.cgi?id=2301454
>
> https://sourceware.org/bugzilla/show_bug.cgi?id=31956

thanks,
sam
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 377 bytes
Desc: not available
URL: <https://sourceware.org/pipermail/binutils/attachments/20240731/e06d33c9/attachment.sig>