RISCV: Support Zilsd and Zcmlsd extensions.

[Jan Beulich]

On 22.07.2024 11:06, 孙东亚 wrote:
> This patch adds support for the Zilsd and Zcmlsd extension, Which is documented at   https://github.com/riscv/riscv-zilsd/releases/tag/v0.9.0 .

There are a number of entirely formal issues here: Your patch looks to be
against an outdated version of binutils; I don't see how it would apply
cleanly, let alone build, on top of current master. There's also a testcase
missing, which ought to cover all new insns. Plus throughout the patch
there appear to be severe problems with indentation. Finally if at all
possible please avoid sending HTML mail. You can see how that looks for me
as plain text both above and below. Hardly readable, I expect you'll agree.

Jan

> Currently, the patch has been merged into https://github.com/nxp-auto-tools/binutils_zilsd by Edmar Wienskoski <edmar.wienskoski@NXP.com>. 
> 
> 
> 
> 
> 
> bfd/ChangeLog:
> 
>  
> 
>         * bfd/elfxx-riscv.c (riscv_parse_check_conflicts):  “zcmlsd” conflict with the “c+f'/ zcf”extension.
> 
>         (riscv_multi_subset_supports):Handle zilsd and zcmlsd.
> 
>         (riscv_multi_subset_supports_ext): Handle zilsd and zcmlsd.
> 
>  
> 
> gas/ChangeLog:
> 
>  
> 
>         *gas/ config/tc-riscv.c (validate_riscv_insn):Add new operand Gd,Gt for zilsd.ld, zilsd.sd.
>         (riscv_ip): Ditto.
>  
> 
> include/ChangeLog:
> 
>  
> 
>         * include/opcode/riscv.h (enum riscv_insn_class):Add INSN_CLASS_ZILSD and INSN_CLASS_ZCMLSD.
> 
>  
> 
> opcodes/ChangeLog:
> 
>  
> 
>         * opcode/riscv-dis.c (print_insn_args): Print zilsd instruction information.
> 
>         * opecode/riscv-opc.c: Add zilsd and zcmlsd instructions.
> 
> 
> 
> ---
> 
>  bfd/elfxx-riscv.c      | 23 +++++++++++++++++++++--
>  gas/config/tc-riscv.c  | 35 +++++++++++++++++++++++++++++++++++
>  include/opcode/riscv.h |  2 ++
>  opcodes/riscv-dis.c    | 18 ++++++++++++++++++
>  opcodes/riscv-opc.c    | 12 ++++++++++++
>  5 files changed, 88 insertions(+), 2 deletions(-)
> 
> 
> Co-developed-by: SUN Dongya <sundongya@nucleisys.com>Co-developed-by: LIU Xu <liuxu@nucleisys.com>Co-developed-by: ZHAO Fujin <zhaofujin@nucleisys.com>Co-developed-by: Edmar Wienskoski <edmar.wienskoski@NXP.com>