[PATCH] ld/PDB: use correct hashing algorithm in add_globals_ref

Mark Harmstone mark@harmstone.com
Sat Jul 20 21:06:29 GMT 2024


Thanks Jan. I'll push this, and send a separate patch fixing all the PDB tests.

>> This is intentional, the tests break if a newline is added.
> 
> Well, no, something _is_ wrong then. There better wouldn't be any such
> files. Assuming that even adding #pass would still result in such breakage
> (all of this testing being open-coded makes me infer that constructs like
> #pass can't be used here at all), I'm inclined to assume objdump is
> producing bogus output then. Or the output is wrongly stripped of the
> trailing newline when processed by the testing machinery. A simple test of
> "objdump -s --target=binary" suggests the latter, albeit the
> "set exp [file_contents ...]" looks innocent enough.

I'm not sure. I remember that I originally copied this idiom from another test,
which presumably would have had the same problem, though I can't find it now.

Mark



More information about the Binutils mailing list