[PATCH v1] LoongArch: Fix ld FAIL test cases

Lulu Cai cailulu@loongson.cn
Thu Jul 18 12:32:49 GMT 2024


On 7/18/24 8:12 PM, Xi Ruoyao wrote:
> On Thu, 2024-07-18 at 20:04 +0800, Lulu Cai wrote:
>
>>> IMO we shouldn't try to support random changes performed by downstream
>>> distros.  If they must do some random changes they should patch the test
>>> suite on their own too.
>> I think so too. But I think we can try to avoid these problems. For the c library search
>> path problem, we can run the test case with gcc instead of ld. For the other problem,
>> adding --no-as-needed to the test can be consistent on all systems.
> But isn't the test suite intended to test *our* ld copy?
>
> Our ld copy cannot be configured with default --as-needed.  So they must
> patch ld to make --as-needed default anyway.  And they can just patch
> the test suite in the same patch.
>
> The problem is it would be a very bad start to support some specific
> downstream change.  Once we start to support distro A, distro B, C, D,
> etc. will attempt to push their specific change.  Then we'll end up one
> of the following consequences:
>
> a. fill the upstream repo with all the adaptions for 42 different
> distros;
>
> or
>
> b. claim Debian is "special" and we only support Debian but not other
> distros.
>
> Both a and b are stupid to me.
>
>
All right. Maybe we can put this question aside for now.




More information about the Binutils mailing list