[PATCH 1/3] gas: sanitize FB- and dollar-label uses

[Matthias Klose]

On 22.03.24 10:40, Jan Beulich wrote:
> I don't view it as sensible to be more lax when it comes to references
> to (uses of) such labels compared to their definition: The latter has
> been limited to decimal numerics, while the former permitted any radix.
> Beyond that leading zeroes on such labels aren't helpful either. Imo
> labels and their use sites would better match literally, to avoid
> confusion.
> 
> As it turns out, one z80 testcase actually had such an odd use of labels
> where definition and use don't match in spelling. That testcase is being
> adjusted accordingly.
> 
> While there also adjust a comment on a local variable in
> integer_constant().
> ---
> Further to this, such label definitions are bounded by INT_MAX, whereas
> label uses can go even into the 64-bit range with BFD64. But perhaps
> that can be viewed as a cosmetic issue, as it only affects what error is
> raised on such label uses.
> 
> The latest seeing the z80 testsuite instance of such a mismatch, I
> wonder whether there's a need for an option to allow people to restore
> original behavior. (As an aside, in that testcase I can't really see the
> purpose of the 2nd 600$ label.)
> 
> Also, despite documentation saying so, -L does not cause any symbols to
> be emitted afaict. Question is whether documentation or implementation
> is wrong.
> 
> --- a/gas/NEWS
> +++ b/gas/NEWS
> @@ -1,5 +1,9 @@
>   -*- text -*-
>   
> +* References to FB and dollar labels, when supported, are no longer permitted
> +  in a radix other than 10.  (Note that definitions of such labels were already
> +  thus restricted, except that leading zeroes were permitted.)

this caused https://bugs.debian.org/1073870, a firefox build failure on 
arm-linux-gnueabihf.  Is this up to firefox to fix?