[PATCH] ld/testsuite: add missing definition to PDB test

Jan Beulich jbeulich@suse.com
Tue Jul 16 06:36:50 GMT 2024


On 16.07.2024 01:44, Mark Harmstone wrote:
> On 15/07/2024 07:22, Jan Beulich wrote:
>> If there was a lack of de-duplication, could you shed some light on ...
>>
>> ... these all being in-place changes? More de-duplication would make
>> at least me expect there's an actual "shift" of content, presumably
>> leading to a reduction in binary size (or individual pieces, not
>> necessarily the entire container). 
> That's because the deduplication is in the type stream, and it's the
> symbols stream we're testing here.

Oh, I see (might be worth mentioning in half a sentence in the description).
Okay then.

Jan

> The old version was creating two types, numbers 0x1002 and 0x1005, when
> it should have merged them. You can see in the hex dumps that the value
> 1005 is changed into 1002, and 100a into 1009 (because everything after
> 1004 moves up one).
> 
> Mark



More information about the Binutils mailing list