[PATCH] elf: Add glibc version dependency only if needed

[H.J. Lu]

On Tue, Jul 9, 2024, 7:06 PM H.J. Lu <hjl.tools@gmail.com> wrote:

>
> On Tue, Jul 9, 2024, 5:30 PM Andreas Schwab <schwab@suse.de> wrote:
>
>> On Jul 09 2024, H.J. Lu wrote:
>>
>> > There is no need to add a needed glibc version if the glibc base version
>> > includes the needed glibc version.
>> >
>> >       PR ld/31966
>> >       * elflink.c (elf_link_add_glibc_verneed): Add glibc_minor_base.
>> >       Skip if the glibc base version includes the needed glibc version.
>> >       (_bfd_elf_link_add_glibc_version_dependency): Initialize
>> >       glibc_minor_base to INT_MAX and pass it to
>> >       elf_link_add_glibc_verneed.
>>
>> Why was this not handled by a special version symbol like
>> GLIBC_ABI_DT_RELR?
>>
>
> It is because the relevant change was
> done in glibc 2.36 well before mark-plt
> change was added to binutils.
>

Fixed on master.  I am backporting it to 2.42 branch.


>
>> --
>> Andreas Schwab, SUSE Labs, schwab@suse.de
>> GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE  1748 E4D4 88E3 0EEA B9D7
>> "And now for something completely different."
>>
>>
>>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://sourceware.org/pipermail/binutils/attachments/20240710/6220da67/attachment.htm>