[PATCH v3 5/7] Add testsuite for ASCII command

[Jens Remus]

Am 08.07.2024 um 17:04 schrieb binutils@emagii.com:
> From: Ulf Samuelsson <ulf@emagii.com>
> 
> Signed-off-by: Ulf Samuelsson <ulf@emagii.com>
> ---
>   ld/testsuite/ld-scripts/ascii.d    | 25 ++++++++++++++++++++
>   ld/testsuite/ld-scripts/ascii.s    | 11 +++++++++
>   ld/testsuite/ld-scripts/ascii.t    | 38 ++++++++++++++++++++++++++++++
>   ld/testsuite/ld-scripts/script.exp |  1 +
>   4 files changed, 75 insertions(+)
>   create mode 100644 ld/testsuite/ld-scripts/ascii.d
>   create mode 100644 ld/testsuite/ld-scripts/ascii.s
>   create mode 100644 ld/testsuite/ld-scripts/ascii.t
> 

...

> diff --git a/ld/testsuite/ld-scripts/ascii.s b/ld/testsuite/ld-scripts/ascii.s
> new file mode 100644
> index 00000000000..a1b6148dc79
> --- /dev/null
> +++ b/ld/testsuite/ld-scripts/ascii.s
> @@ -0,0 +1,11 @@
> +        .extern ecc_start

Nit: Use a tab instead of the 8 spaces for indentation.

> +	.section .text
> +main:
> +	.long 0x45444F43
> +	.long 0x12345678
> +	
> +	.section .data
> +	.long 0x9abcdef0
> +	
> +	.section .bss
> +	.long 0

...

Regards,
Jens
-- 
Jens Remus
Linux on Z Development (D3303) and z/VSE Support
+49-7031-16-1128 Office
jremus@de.ibm.com

IBM

IBM Deutschland Research & Development GmbH; Vorsitzender des 
Aufsichtsrats: Wolfgang Wendt; Geschäftsführung: David Faller; Sitz der 
Gesellschaft: Böblingen; Registergericht: Amtsgericht Stuttgart, HRB 243294
IBM Data Privacy Statement: https://www.ibm.com/privacy/