[PATCH v1 2/3] gas: add new command line options to control diagnostic information messages

Matthieu Longo matthieu.longo@arm.com
Wed Jul 3 16:52:09 GMT 2024


On 2024-07-03 08:55, Jan Beulich wrote:
> On 02.07.2024 19:40, Matthieu Longo wrote:
>>
>> gas currently emits information messages for context information along warnings.
>> In the context of system register tests in AArch64 backend, these messages
>> pollute the tests when checking for error message patterns in stderr output.
>>
>> This patch aims at providing two new flags while preserving the existing
>> behavior if none of the options is provided.
>>    * --info, similar to the existing --warn flag to enable diagnostic
>>      information messages (default behavior).
>>    * --no-info, similar to the existing --no-warn flag to disable diagnostic
>>      information messages.
> 
> Nick, Alan, what is your take on these option names? Having dropped the 's'
> from the original form is an improvement imo, but I'm a little afraid "info"
> (unlike "warn") may become ambiguous with something else down the road.
> 
>> It also adds the flags to the existing documentation, and command manual.
> 
> In all of the doc changes you appear to be entirely ignoring the present
> alphabetical sorting in the blocks you insert into. The info additions
> want to all move further up; the sorting there isn't on a "related to one
> another" basis afaics.
> 
>> ---
>>   gas/as.c                | 18 +++++++++++++++++-
>>   gas/as.h                |  3 +++
>>   gas/config/tc-aarch64.c |  3 +++
> 
> This change will need explicit buy-off by Arm64 folks. Mind me asking why
> you Cc-ed only Richard, but not Marcus?

Although Marcus Shawcroft is listed in the maintainers file, he works on 
others things these days (but still at Arm).

> Jan
> 
>>   gas/doc/as.texi         | 34 ++++++++++++++++++++++++++++++++++
>>   gas/messages.c          |  3 +++
>>   5 files changed, 60 insertions(+), 1 deletion(-)
>>


More information about the Binutils mailing list