[PATCH] RISC-V: hash with segment id and pcrel_hi address while recording pcrel_hi
Jan Beulich
jbeulich@suse.com
Tue Jul 2 06:25:34 GMT 2024
On 02.07.2024 05:20, lifang_xia wrote:
>> 2024年6月25日 16:25,Jan Beulich <jbeulich@suse.com> 写道:
>> I don't really understand, though, why htab_hash_pointer() wants / needs
>> using here. Wouldn't (deriving from what was there before)
>> "e->address + 59 * e->seg->id" suffice (multiplier subject to possible
>> improvement), and be less of a behavioral change?
> "e->address + 59 * e->seg->id” would be fine. It's just necessary
> to ensure uniqueness within a finite range.
> As for the multiplier, do you have any suggestions? I feel that 59 might be
> too small. Is 127 a better choice?
Why would you think the absolute value matters much? As to 127, I'd view
this as sub-optimal, for being 2^^7-1 (i.e. a little too "regular"). But
surely you should be fine picking whatever larger prime you like.
Jan
More information about the Binutils
mailing list