[PATCH 07/11] gas: consistently drop trailing whitespace when scrubbing

Jan Beulich jbeulich@suse.com
Mon Jul 1 05:58:36 GMT 2024


On 28.06.2024 15:53, Maciej W. Rozycki wrote:
> On Fri, 28 Jun 2024, Jan Beulich wrote:
> 
>> >From especially the checks for the two separator forms it appears to
> 
>  Accidental `>' here?

Indeed. Don't have that locally, so not really sure where it came from.

>> In the MIPS testsuite adjustments I wasn't sure how exactly to make the
>> necessary changes: I could also have zapped the two blanks each, but
>> then I wondered why they were part of the expectations in the first
>> place.
> 
>  Please do.

Done locally; I won't post a v2 just for this, though.

>  The only reason I can think of why the patterns are such as they are is 
> that they need to match the output as it has been produced.  It made no 
> sense to make whitespace matching optional when said whitespace is always 
> there.

But the purpose of those tests isn't the _exact_ output that gas would
produce, is it? The presence / absence of whitespace in most tests
really is entirely unrelated to what is being tested. Just to mention
it ...

Jan


More information about the Binutils mailing list