[PATCH, V2 2/2] gas: scfi: untraceable control flow should be a hard error

[Jan Beulich]

On 24.01.2024 08:26, Indu Bhagat wrote:
> --- a/gas/ginsn.c
> +++ b/gas/ginsn.c
> @@ -1161,8 +1161,8 @@ ginsn_data_end (const symbolS *label)
>    /* Build the cfg of ginsn(s) of the function.  */
>    if (!frchain_now->frch_ginsn_data->gcfg_apt_p)
>      {
> -      as_warn (_("Untraceable control flow for func '%s'; Skipping SCFI"),
> -	       S_GET_NAME (func));
> +      as_bad (_("SCFI: untraceable control flow for func '%s'"),
> +	      S_GET_NAME (func));
>        goto end;
>      }

This switch is probably fine. My question here is: How come ginsn.c issues
an SCFI-specific diagnostic? Really most if not all of ginsn_data_end() looks
to be concerned of only SCFI, when e.g. ginsn_pass_warn_unreachable_code()
might have value on its own.

Jan