[PATCH,V2 0/2] Testcase refactoring and fix PR gas/31284

Indu Bhagat indu.bhagat@oracle.com
Wed Jan 24 07:26:27 GMT 2024


Hi,

When fixing PR gas/31284, I realised that the existing testcase for
change of flow instructions could use some refactoring.

I think applying the two patches to binutils 2.42 branch may be a good
idea because issuing an error is a clearer message than the previous
warning.  More details in the commit log of Patch 2/2.  What is your
opinion ?

Thanks,
Indu Bhagat (2):
  x86: testsuite: scfi: adjust COFI testcase
  gas: scfi: untraceable control flow should be a hard error

 gas/ginsn.c                                   |  4 +-
 gas/testsuite/gas/scfi/x86_64/ginsn-cofi-1.l  | 38 +++++++++++++++++++
 .../x86_64/{scfi-cofi-1.s => ginsn-cofi-1.s}  |  4 --
 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.d   |  5 ---
 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.l   |  3 --
 .../gas/scfi/x86_64/scfi-unsupported-cfg-1.l  |  2 +-
 gas/testsuite/gas/scfi/x86_64/scfi-x86-64.exp |  3 +-
 7 files changed, 42 insertions(+), 17 deletions(-)
 create mode 100644 gas/testsuite/gas/scfi/x86_64/ginsn-cofi-1.l
 rename gas/testsuite/gas/scfi/x86_64/{scfi-cofi-1.s => ginsn-cofi-1.s} (84%)
 delete mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.d
 delete mode 100644 gas/testsuite/gas/scfi/x86_64/scfi-cofi-1.l

-- 
2.43.0



More information about the Binutils mailing list