[PATCH]Enforce C++11 as a minimum for building gold [PR30867]

[Tamar Christina]

> -----Original Message-----
> From: Tom Tromey <tom@tromey.com>
> Sent: Wednesday, January 10, 2024 5:46 PM
> To: Tamar Christina <Tamar.Christina@arm.com>
> Cc: binutils@sourceware.org; nd <nd@arm.com>; iant@google.com;
> ccoutant@gmail.com
> Subject: Re: [PATCH]Enforce C++11 as a minimum for building gold [PR30867]
> 
> >>>>> "Tamar" == Tamar Christina <tamar.christina@arm.com> writes:
> 
> Tamar> This commit has unconditionally introduced C++11 types without
> Tamar> changing the build system to require a C++ compiler.
> 
> Tamar> --- a/gold/aclocal.m4
> Tamar> +++ b/gold/aclocal.m4
> Tamar> @@ -108,6 +108,1025 @@ AC_DEFUN([AM_AUX_DIR_EXPAND],
> Tamar>  am_aux_dir=`cd "$ac_aux_dir" && pwd`
> Tamar>  ])
> 
> Tamar> +#
> ======================================================================
> =====
> Tamar> +#  https://www.gnu.org/software/autoconf-
> archive/ax_cxx_compile_stdcxx.html
> Tamar> +#
> ======================================================================
> =====
> Tamar> +#
> Tamar> +# SYNOPSIS
> Tamar> +#
> 
> This macro is already in config/ax_cxx_compile_stdcxx.m4 and you can
> replace the in-line definition with an m4_include, see the end of
> gold/aclocal.m4.
> 

The inlining was done by autoconf when it regenerated the files.  Same thing as in
maintainer mode so how does one prevent it from doing so?  Manually editing the
file will trigger errors from the sourceware CI.

Tamar

> For some reason gdb has its own copy of this macro as well, seems like a
> mistake.
> 
> Tom